Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor ActionManagementDAO to handle action type specific properties #6119

Open
wants to merge 27 commits into
base: master
Choose a base branch
from

Conversation

ashanthamara
Copy link
Contributor

@ashanthamara ashanthamara commented Nov 10, 2024

Proposed changes in this pull request

  1. With this PR, ActionManagementDAO will be able to handle properties specific to each actionTypes. (Currently for PRE_ISSUE_ACCESS_TOKEN and PRE_UPDATE_PASSWORD)
  2. action-mgt component will utilize certificate-mgt for the operations related to the certificates used in PRE_UPDATE_PASSWORD action type.
  3. Also with this PR, the updateActionEndpointAuthentication will be removed as it has no use case in the product
  4. The IDN_ACTION_ENDPOINT table will be renamed to IDN_ACTION_PROPERTIES and now it will be utilize to store action type related properties as well.

Related Issue

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

Attention: Patch coverage is 81.32911% with 118 lines in your changes missing coverage. Please review.

Project coverage is 44.94%. Comparing base (37bd1b3) to head (931588f).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
...n/management/dao/impl/ActionManagementDAOImpl.java 87.83% 20 Missing and 3 partials ⚠️
...management/dao/impl/ActionManagementDAOFacade.java 84.21% 20 Missing and 1 partial ⚠️
...management/internal/ActionMgtServiceComponent.java 0.00% 21 Missing ⚠️
...ity/action/management/service/ActionConverter.java 0.00% 16 Missing ⚠️
...ment/service/impl/ActionManagementServiceImpl.java 81.94% 7 Missing and 6 partials ⚠️
...dentity/action/management/dao/model/ActionDTO.java 88.75% 6 Missing and 3 partials ⚠️
...ion/management/service/ActionPropertyResolver.java 0.00% 4 Missing ⚠️
...rvice/impl/CacheBackedActionManagementService.java 91.17% 2 Missing and 1 partial ⚠️
...gement/dao/impl/ActionPropertyResolverFactory.java 77.77% 1 Missing and 1 partial ⚠️
...entity/action/management/model/Authentication.java 0.00% 2 Missing ⚠️
... and 3 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master    #6119      +/-   ##
============================================
+ Coverage     44.68%   44.94%   +0.26%     
- Complexity    13529    13692     +163     
============================================
  Files          1579     1593      +14     
  Lines         99162    99816     +654     
  Branches      16124    16162      +38     
============================================
+ Hits          44307    44860     +553     
- Misses        48179    48234      +55     
- Partials       6676     6722      +46     
Flag Coverage Δ
unit 26.85% <81.32%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11768640854

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11768640854
Status: failure

Copy link

sonarcloud bot commented Nov 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants