Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce new authenticator properties: DefinedBy #6037

Merged
merged 17 commits into from
Oct 18, 2024
Merged

Introduce new authenticator properties: DefinedBy #6037

merged 17 commits into from
Oct 18, 2024

Conversation

Thisara-Welmilla
Copy link
Contributor

@Thisara-Welmilla
Add definedBy type property.
e80bd5c
@Thisara-Welmilla
Address comments
eb2ca3b
@Thisara-Welmilla
Add definedBy property to databases.
9856e5d
@Thisara-Welmilla
Reduce varchar length
98816d3
@Thisara-Welmilla
Merge pull request #5991 from Thisara-Welmilla/add-definedBy-type-pro…
5f1b008 
…p-db

Add definedBy property for authenticator databases.
@Thisara-Welmilla
Merge pull request #5990 from Thisara-Welmilla/add-definedBy-type-prop
9ff18dd 
Add definedBy property for authenticators.
@Thisara-Welmilla
Improve unit tests.
0e9ad5f
@Thisara-Welmilla
Update wsdl files.
964c356
@Thisara-Welmilla
Improve framework to resolve the definedBy authenticator property.
c5e977d
@Thisara-Welmilla
Merge pull request #6017 from Thisara-Welmilla/add-unit-test
13ee92f 
Improve unit tests for introducing new authenticator property
@Thisara-Welmilla
Resolve wsdl file conflict.
6d89ddb
@Thisara-Welmilla
Merge pull request #6030 from Thisara-Welmilla/resolve-conflicts
611ad40 
Resolve wsdl file conflict.
@Thisara-Welmilla
Merge pull request #6029 from Thisara-Welmilla/improve-resolve-suth-prop
bdc2fb4 
Improve framework to resolve the definedBy authenticator property
@Thisara-Welmilla
Merge branch 'master' into add-definedBy-Type
8fa77b8
@Thisara-Welmilla
Update IdentityApplicationManagementService.wsdl
1a318e6
@Thisara-Welmilla
Update wsdl files.
bbbc6da
@Thisara-Welmilla
Merge pull request #6035 from Thisara-Welmilla/update_wsdl_files
5911bff 
Update wsdl files.
@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11364205783

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11364205783
Status: failure

@jenkins-is-staging
Copy link

PR builder started
Link: https://github.com/wso2/product-is/actions/runs/11364631074

@jenkins-is-staging
Copy link

PR builder completed
Link: https://github.com/wso2/product-is/actions/runs/11364631074
Status: success

jenkins-is-staging
jenkins-is-staging approved these changes Oct 16, 2024
View reviewed changes
Copy link

@jenkins-is-staging jenkins-is-staging left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the pull request based on the successful pr build https://github.com/wso2/product-is/actions/runs/11364631074

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 17, 2024

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
1.7% Duplication on New Code

See analysis details on SonarCloud

@Thisara-Welmilla Thisara-Welmilla merged commit 92ea714 into master Oct 18, 2024
6 of 7 checks passed
@Thisara-Welmilla Thisara-Welmilla mentioned this pull request Oct 18, 2024
Merged
@Thisara-Welmilla Thisara-Welmilla deleted the add-definedBy-Type branch November 11, 2024 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenkins-is-staging jenkins-is-staging jenkins-is-staging approved these changes

@malithie malithie malithie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Thisara-Welmilla @jenkins-is-staging @malithie