New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integrate secret management to action-mgt component #5795

Merged

ashanthamara merged 8 commits into wso2:master from ashanthamara:actions

Jul 17, 2024

Contributor

ashanthamara commented Jul 15, 2024 •

edited

Loading

Proposed changes in this pull request

This PR will cover adding secret management to the action-mgt component using the secret-mgt component.

Introduced ActionSecretProcessor as a wrapper class for accessing SecretManager and the SecretResolveManager.
Will not expose the secrets after adding them to the system.
Wrote a method in the AuthType class to get the decrypted secrets for internal usages.
Changed Action Update PUT endpoint to a PATCH endpoint.
Added new endpoint to update authentication properties.
- https://app.swaggerhub.com/apis/ASHANTEST02/actions/1.0.0

Related Issue:

Secure the secrets in Action Management component product-is#20750

Related PRs

ashanthamara added 2 commits

July 15, 2024 11:51


          Integrate secret-management to action-mgt component

d346886


          Merge remote-tracking branch 'upstream/master' into actions

9862b2a

ashanthamara mentioned this pull request

Integrate secret-management to action-management component wso2/identity-api-server#630

Merged

malithie reviewed

View reviewed changes

...nt/src/main/java/org/wso2/carbon/identity/action/management/ActionManagementServiceImpl.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nt/src/main/java/org/wso2/carbon/identity/action/management/ActionManagementServiceImpl.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nt/src/main/java/org/wso2/carbon/identity/action/management/ActionManagementServiceImpl.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nt/src/main/java/org/wso2/carbon/identity/action/management/ActionManagementServiceImpl.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nagement/src/main/java/org/wso2/carbon/identity/action/management/ActionSecretProcessor.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nagement/src/main/java/org/wso2/carbon/identity/action/management/ActionSecretProcessor.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...nt/src/main/java/org/wso2/carbon/identity/action/management/constant/ActionMgtConstants.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

...c/main/java/org/wso2/carbon/identity/action/management/dao/impl/ActionManagementDAOImpl.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...c/main/java/org/wso2/carbon/identity/action/management/dao/impl/ActionManagementDAOImpl.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

...tion.management/src/main/java/org/wso2/carbon/identity/action/management/model/AuthType.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...tion.management/src/main/java/org/wso2/carbon/identity/action/management/model/AuthType.java Outdated Show resolved Hide resolved

ashanthamara added 3 commits

July 16, 2024 17:37


          Add few improvements

4c40292


          Merge remote-tracking branch 'upstream/master' into actions

64680fa


          Update other db scripts

f7d0dca

malithie reviewed

View reviewed changes

...nagement/src/main/java/org/wso2/carbon/identity/action/management/ActionSecretProcessor.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...c/main/java/org/wso2/carbon/identity/action/management/dao/impl/ActionManagementDAOImpl.java Outdated Show resolved Hide resolved

malithie reviewed

View reviewed changes

...c/main/java/org/wso2/carbon/identity/action/management/dao/impl/CacheBackedActionMgtDAO.java Show resolved Hide resolved

malithie reviewed

View reviewed changes

....management/src/main/java/org/wso2/carbon/identity/action/management/model/AuthProperty.java Outdated Show resolved Hide resolved

ashanthamara added 3 commits

July 16, 2024 20:03


          Address comments

d2420ad


          Fix spotbug issue

3b2f225


          Fix spotbug issue

32791bd

malithie approved these changes

View reviewed changes

ashanthamara merged commit 27f403e into wso2:master

2 checks passed

This was referenced Jul 17, 2024

Update integration tests of action-mgt rest api. wso2/product-is#20706

Merged

Secure the secrets in Action Management component wso2/product-is#20750

Closed

ashanthamara mentioned this pull request

Implement action management to configure and manage external endpoints invoked synchronously in product flows wso2/product-is#20747

Closed

7 tasks

ashanthamara mentioned this pull request

Add Action Management REST API wso2/product-is#20748

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet