Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #487 cta banners changes. #337

Merged
merged 2 commits into from
Nov 27, 2024
Merged

Issue #487 cta banners changes. #337

merged 2 commits into from
Nov 27, 2024

Conversation

mariacha
Copy link
Collaborator

What issue(s) does this solve?

What is the new behavior?

  • Comments out clickOutsideModal (too easy to dismiss)
  • Adds the name of the classy cookie

Profile requirements:

  • Does deploying this change require a change to config at the site level (choose one)?
    • No config change is required.
    • Yes, and I have written an update hook to apply these config changes.
    • Yes, and I've included updating instructions to be added to the release notes. The next release will need to be a major version increase. (Only do this in special cases.)

Site-level pull requests for testing. Only merge when these PRs are approved:

Create or update any site-level pull requests following the documentation

  • Flagship PR:

Checked on develop (TA to do)

  • Brasil
  • China
  • Indonesia

@mariacha mariacha merged commit d8c2b6b into main Nov 27, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant