Initial work #77
Merged
Initial work #77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It took some fiddling around, but I got all workflow to pass using Conda. |
kcartier-wri
deleted the
CIF-204-CORE-Use-Conda-for-running-tests-in-Github-Actions
branch
chrowe
reviewed
Sep 13, 2024
| python -m pip install --upgrade pip | ||
| pip install -r .github/requirements.txt | ||
| pip install GDAL==`gdal-config --version` | ||
| conda install pytest --yes |
There was a problem hiding this comment.
Isn't pytest installed in cities-cif? Why do we need it installed here?
There was a problem hiding this comment.
Is there a reason to use a separate file for Actions vs just using the main project one?
|
Two good points and better solution. Implemented in #79 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converting Actions workflow to use Conda .