Modification in bats.yaml

[anushkamittal20]

Adds a more detailed bats package to match upstream

[EyeCantCU]

Is it intended that we move over everything?

[anushkamittal20]

Hey RJ, thanks for the review. The reason we needed to add all of this was to match the upstream image. https://github.com/bats-core/bats-core/blob/master/Dockerfile where the entire repo is shifted and the link that I created above is also created.

[EyeCantCU]

In that case, could we remove the .git folder? And anything else it may not actually be using at runtime?

[anushkamittal20]

I compared the dir in my image:

bash-5.2$ ls /opt/bats
AUTHORS                       docker                        man
Dockerfile                    docker-compose.override.dist  package.json
LICENSE.md                    docker-compose.yml            shellcheck.sh
README.md                     docs                          test
SECURITY.md                   install.sh                    uninstall.sh
bin                           lib
contrib                       libexec

vs upstream

/code # ls /opt/bats
AUTHORS                       bin                           docs                          package.json
Dockerfile                    contrib                       install.sh                    shellcheck.sh
LICENSE.md                    docker                        lib                           test
README.md                     docker-compose.override.dist  libexec                       uninstall.sh
SECURITY.md                   docker-compose.yml            man

both are the same

[anushkamittal20]

Should I explicitly look at removing items?

[developer-guy]

https://github.com/bats-core/bats-core/blob/89a7fae3b651d5c2f42a3874ec32e821014814eb/docker/install_libs.sh#L32 I saw that it downloads the files from their own repositories like https://github.com/bats-core/bats-support, so creating a separate packages for them like support, file, assert and detik would be great cuz in that case it'd be easier to keep these things in sync when there is a new version come up, but I'm not certain though.

[anushkamittal20]

you mean like subpackages or completely new packages?

[developer-guy]

writing some tests would be great here:

for example:
cat < example.sh
#!/bin/bash

Function to add two numbers

add_numbers() {
echo $(( $1 + $2 ))
}

Function to check if a file exists

file_exists() {
if [[ -f "$1" ]]; then
echo "true"
else
echo "false"
fi
}

Function to check if a string contains another string

string_contains() {
if [[ "$1" == "$2" ]]; then
echo "true"
else
echo "false"
fi
}
EOF

cat <
#!/usr/bin/env bats

Load the script to test

load_file() {
source "./example.sh"
}

setup() {
# This runs before every test
load_file
}

teardown() {
# This runs after every test
rm -f testfile.txt
}

@test "add_numbers should correctly add two numbers" {
run add_numbers 3 5
[ "$status" -eq 0 ]
[ "$output" -eq 8 ]
}

@test "file_exists should return true for existing file" {
touch testfile.txt
run file_exists testfile.txt
[ "$status" -eq 0 ]
[ "$output" = "true" ]
}

@test "file_exists should return false for non-existing file" {
run file_exists non_existing_file.txt
[ "$status" -eq 0 ]
[ "$output" = "false" ]
}

@test "string_contains should return true if substring is found" {
run string_contains "hello world" "hello"
[ "$status" -eq 0 ]
[ "$output" = "true" ]
}

@test "string_contains should return false if substring is not found" {
run string_contains "hello world" "bye"
[ "$status" -eq 0 ]
[ "$output" = "false" ]
}
EOF

[anushkamittal20]

Sure thing!