py3-grpcio-gcp: Add python multiversion support #34721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannf
added a commit
to dannf/os
that referenced
this pull request
Nov 20, 2024
This does not include a conversion to py/pip-build-install because it does not appear to support building a subdirectory. python3.13 support is not included because it is blocked by a 3.13 build of py3-grpcio-gcp (wolfi-dev#34721). Signed-off-by: dann frazier <[email protected]>
dannf
added a commit
to dannf/os
that referenced
this pull request
Nov 20, 2024
This does not include a conversion to py/pip-build-install because it does not appear to support building a subdirectory. python3.13 support is not included because it is blocked by a 3.13 build of py3-grpcio-gcp (wolfi-dev#34721). Signed-off-by: dann frazier <[email protected]>
dannf
added a commit
to dannf/os
that referenced
this pull request
Nov 21, 2024
This does not include a conversion to py/pip-build-install because it does not appear to support building a subdirectory. python3.13 support is not included because it is blocked by a 3.13 build of py3-grpcio-gcp (wolfi-dev#34721). Signed-off-by: dann frazier <[email protected]>
dannf
added
the
approved-to-run
octo-sts
bot
added
the
bincapz/pass
dannf
force-pushed
the
multiversion/py3-grpcio-gcp
branch
3 times, most recently
from
0f535b4
to
5b4718f
Compare
dannf
force-pushed
the
multiversion/py3-grpcio-gcp
branch
2 times, most recently
from
63eaa40
to
261c4ea
Compare
Python modules may be provided in subdirectories of the upstream source. Signed-off-by: dann frazier <[email protected]>
Building from the tarball results in an unusable package because the included grpc_gcp_pb2.py is generated from an old protobuf. The tarball includes the .proto file we need to generate a new one. Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
dannf
force-pushed
the
multiversion/py3-grpcio-gcp
branch
from
261c4ea
to
be8c0d3
Compare
xnox
approved these changes
Nov 25, 2024
smoser
reviewed
Nov 25, 2024
smoser
reviewed
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: https://github.com/chainguard-dev/internal-dev/issues/5334
From the individual commits: