Add abseil-cpp spec to workaround GCC issue w/ openssf-compiler-options #34201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannf
force-pushed
the
abseil-cpp-gcc-spec
branch
from
9e6a2ec
to
500fb54
Compare
dannf
force-pushed
the
abseil-cpp-gcc-spec
branch
from
500fb54
to
9579b82
Compare
justinvreeland
previously approved these changes
Nov 15, 2024
justinvreeland
added
the
approved-to-run
dannf
force-pushed
the
abseil-cpp-gcc-spec
branch
from
9579b82
to
24464af
Compare
|
The elastic build of libreoffice failed because it didn't actually have a build-dep on |
dannf
force-pushed
the
abseil-cpp-gcc-spec
branch
from
24464af
to
2357acd
Compare
dannf
added
the
blocked
dannf
force-pushed
the
abseil-cpp-gcc-spec
branch
from
2357acd
to
171fef5
Compare
|
I've pushed a new version that puts the spec files in a new |
Signed-off-by: wolfi-bot <[email protected]>
Signed-off-by: wolfi-bot <[email protected]>
Signed-off-by: wolfi-bot <[email protected]>
…C bug abseil-cpp and packages that use it began to FTBFS after the introduction of openssf-compiler-options, specifically its addition of the -fno-delete-null-pointer-checks flag. This is believed to be a GCC bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=71962 Unfortunately it isn't possible to "undo" this flag by appending the inverse flag (-fdelete-null-pointer-checks). So here we introduce a new package that provides a spec file that will filter out the problematic flag from the openssf spec file. Fixes wolfi-dev#34075. This commit uses the spec file to build abseil-cpp itself, and ships it in the abseil-cpp-compiler-options apk so abseil-cpp's reverse dependencies, as well as packages that vendor their own abseil-cpp source, can be updated to use it. Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
`python3` is explicitly called in the pipeline so we should have an explicit dependency on it. This was causing us to FTBFS until recently, when we inherited `python3` as a transitive dependency of `cython-0`. Fixes: bb98184 ("make grpc-1.67 multi-version python. (wolfi-dev#31676)")
Without py3.13-cython, the build will fail once we add python3.13
support with errors like:
src/python/grpcio/grpc/_cython/cygrpc.cpp: In function 'void __Pyx_init_assertions_enabled()':
src/python/grpcio/grpc/_cython/cygrpc.cpp:6399:39: error: '_PyInterpreterState_GetConfig' was not declared in this scope; did you mean 'PyInterpreterState_GetID'?
6399 | __pyx_assertions_enabled_flag = ! _PyInterpreterState_GetConfig(__Pyx_PyThreadState_Current->interp)->optimization_level;
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
| PyInterpreterState_GetID
cython-0 and py3.12-cython currently contain overlapping files, so
we can't have both installed. grpc-1.67 builds fine w/o cython-0,
so let's just drop it.
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
Signed-off-by: dann frazier <[email protected]>
…tions See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
See: wolfi-dev#34075 Signed-off-by: dann frazier <[email protected]>
justinvreeland
force-pushed
the
abseil-cpp-gcc-spec
branch
from
171fef5
to
0b82da4
Compare
This was referenced Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #34075
Also merges a few automated package update PRs that were blocked by this.
Blocked by chainguard-dev/melange#1651