Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/trim native tls and features #187

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mlemesle
Copy link
Contributor

@mlemesle mlemesle commented Apr 7, 2023

Supersedes #184

Closes #176 and #180

Hey there, I started again and successfully trimed native-tls from the dependencies and moved tokio-native-tls to rustls-webpki. All tests pass for async-std and tokio-runtime !

There is still some work to do:

  • Adapt Connectors configuration to rustls
  • Trim other dependencies
  • Rework the features => move async_gremlin to __async_gremlin, to show developers not to use it

I also added a compilation failure if someone tries to use async-std-runtime and tokio-runtime at the same time.

What do you think of this ?

@wolf4ood
Copy link
Owner

wolf4ood commented Apr 7, 2023

@mlemesle

looks great, just one thing, why the tungstenite dep is via github? is it missing something there yet not released?

@mlemesle
Copy link
Contributor Author

mlemesle commented Apr 7, 2023

I forgot to mention. There was a lot of dep version issues.
I had to fork 3 dependencies in order to fix this...
PR are submitted, I'm waiting for a release to add it to Cargo.toml!

What about my previous points?
Like moving async_gremlin to __async_gremlin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Native TLS as optional
2 participants