Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit default scopes #43

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ShawnCZek
Copy link
Contributor

@ShawnCZek ShawnCZek commented Dec 28, 2022

The default scopes were flawed because many of them are not vital for providing the basic user interface:

This should not be a complete list of all scopes, but the minimum required for the provider user interface!

Whether the email scope should be included as well is for discussion. Nevertheless, since DiscordResourceOwner provides a getter for the email address, I have included it, too.

This is a breaking change because if the developer does not specify the scopes, their existing authorization grants will become invalid. As a result of this, existing users will have to reauthorize (due to the change of scopes). On the other hand, starting with this library will be easier for new developers as, most of the time, different scopes are unnecessary.

@wohali
Copy link
Owner

wohali commented Dec 29, 2022

Need to think about this one.

@ShawnCZek
Copy link
Contributor Author

Just my two cents: if you decide to release a new major version because of this, it would be worth dropping the support of PHP 7.x versions. They are barely used, and their usage should be discouraged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants