Support v-for="(item, index)" #15
Conversation
|
CI fails on PHP 5.5 and HHVM; I’m proposing to kick those out of |
|
Needs a rebase apparently D: |
This adds rudimentary support for iterating over a value with the optional second argument for the index. (Because lists and objects are so similar in PHP, this also doubles as support for iterating over an object with the optional second argument for the key; the optional third argument for the index in that case is not supported, though.) Note that, due to the limited JS evaluation in this templating engine, there’s not a whole lot you can do with the index. In the WikibaseLexeme use case, the index is only actually used in a part of the template that’s never server-side rendered; the loop still has to be declared using the index form even for the PHP renderer, though. The unrelated change from v-else="" to v-else in the fixtures was generated by `npm run-script populate-fixtures`, presumably due to a newer Vue.js version now being used – we don’t commit the package-lock.json (yet?). I figured I might as well add it, since one of the fixtures is changed anyways to test the feature.
lucaswerkmeister
force-pushed
the
for-index
branch
from
0a78f43
to
f7e676f
Compare
|
Done (conflicted with the change from |
| @@ -240,10 +240,21 @@ private function handleFor( DOMNode $node, array $data ) { | |||
| list( $itemName, $listName ) = explode( ' in ', $node->getAttribute( 'v-for' ) ); | |||
| $node->removeAttribute( 'v-for' ); | |||
|
|
|||
| foreach ( $data[$listName] as $item ) { | |||
| if ( preg_match( '/\((?P<itemName>[^,]+)\s*,\s*(?P<keyName>[^\)]+)\)/', $itemName, $matches ) ) { | |||
There was a problem hiding this comment.
Note that this uses an extremely crude regex to match variable names; I’m not sure if this library has a better regex (snippet) for that elsewhere, though.
|
Should I leave this to see how things continue to develop with the gerrit patch? (https://gerrit.wikimedia.org/r/#/c/mediawiki/extensions/WikibaseLexeme/+/589656/ ) or would you rather this get looked at now? :) |
|
We can leave this alone for now, I think. |
|
This is no longer required for the focus changes. We could still merge it if we want to, or leave it open until someone else needs it…? |
This adds rudimentary support for iterating over a value with the optional second argument for the index. (Because lists and objects are so similar in PHP, this also doubles as support for iterating over an object with the optional second argument for the key; the optional third argument for the index in that case is not supported, though.)
Note that, due to the limited JS evaluation in this templating engine, there’s not a whole lot you can do with the index. In the WikibaseLexeme use case, the index is only actually used in a part of the template that’s never server-side rendered; the loop still has to be declared using the index form even for the PHP renderer, though.
The unrelated change from
v-else=""tov-elsein the fixtures was generated bynpm run-script populate-fixtures, presumably due to a newer Vue.js version now being used – we don’t commit thepackage-lock.json(yet?). I figured I might as well add it, since one of the fixtures is changed anyways to test the feature.The corresponding WikibaseLexeme change is I9b41958eec.