Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add Rosetta Simulator Instructions #4599

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kagrawal98
Copy link

@kagrawal98 kagrawal98 commented Oct 6, 2024

Description

Fixes #4571

This PR adds a new section to the "Building the App" troubleshooting guide, specifically addressing issues that may arise when running Detox in a Rosetta environment on Apple Silicon Macs.

  • Added a new subsection titled "Running Detox in a Rosetta environment"
  • Provided step-by-step instructions to resolve SwiftEmitModule or SwiftCompile errors
  • Included code snippets for modifying the Detox configuration and running necessary terminal commands

Why is this important?

As more developers transition to Apple Silicon Macs, it's crucial to provide guidance on running tools like Detox in Rosetta environments. This addition will help users troubleshoot and resolve common issues, improving their development experience.


For features/enhancements:

  • I have added/updated the relevant references in the documentation files.

For API changes:

  • I have made the necessary changes in the types index file.

@kagrawal98 kagrawal98 changed the title chore: Add Rosetta Simulator Instructions docs: Add Rosetta Simulator Instructions Oct 6, 2024
@kagrawal98 kagrawal98 changed the title docs: Add Rosetta Simulator Instructions docs: add Rosetta Simulator Instructions Oct 6, 2024
@d4vidi
Copy link
Collaborator

d4vidi commented Oct 6, 2024

Thanks a lot, @kagrawal98! Are you and @differenzPriv aligned on the solution?

@d4vidi
Copy link
Collaborator

d4vidi commented Oct 6, 2024

In any case, you seem to have edited the document in the wrong path. Should be easy to fix.
As per content, @asafkorem - WDYT?

@d1fferenz
Copy link

d1fferenz commented Oct 6, 2024

In any case, you seem to have edited the document in the wrong path. Should be easy to fix. As per content, @asafkorem - WDYT?

Thanks @d4vidi for tagging me and keeping me in the loop! I haven't forgotten to contribute to the repository in relation to the rosetta trouble shooting solution, but my time has been quite limited over the past few weeks.

I agree with the addition @kagrawal98 made to the README. The solution includes all the key elements needed to solve the problem. 👍🏻

@d4vidi
Copy link
Collaborator

d4vidi commented Oct 7, 2024

I agree with the addition @kagrawal98 made to the README. The solution includes all the key elements needed to solve the problem. 👍🏻

@differenzPriv thanks, that's what I needed to know

@asafkorem
Copy link
Contributor

@kagrawal98, you've edited the snapshotted version of building-the-app.md (Detox v20). Please edit the most up-to-date document instead (under docs/troubleshooting/building-the-app.md)

Comment on lines +136 to +140
1. Modify your build command in the Detox configuration:

```json
"build": "xcodebuild -workspace ios/MyApp.xcworkspace -scheme MyApp -configuration Debug -sdk iphonesimulator -arch x86_64 -derivedDataPath ios/build"
```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example is not enough, please emphasize that it's done by specifying arch=x86_64

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it will also work if you'll set that from the project's build settings

image

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@asafkorem Setting it via the build settings might lead to conflicts with the necessary configuration for the app. In my project, for instance, I need specific build settings due to different dependencies. My goal is to adjust the architecture specifically for running the Detox tests, without altering the overall app build. That's why I chose to modify only the Detox build command. I want to emphasize that this is about changing Detox’s behavior, not my app’s – a crucial distinction!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@differenzPriv True, I get your point. If your app can run in the Rosetta environment on Apple Silicon without Detox, then Detox is the only concern here, and your approach makes perfect sense. However, if that's not the case, it would be reasonable to add this architecture under the Debug configuration in Xcode. It might be worth mentioning this distinction in the doc IMO.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Xcode, you can enable "Show All Simulators". Here, we select the Rosetta simulator for the normal build. In the "Excluded Architectures" tab, we select the "arm64" architecture, not "x86_64". So, in my case, I only need to change the architecture for the "detox-build-command" and not the general one.

I like your suggestion to mention this distinction for better understanding and for choosing the right solution for a specific use case. 👍🏻

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense @differenzPriv.
@kagrawal98 can you add this note?

@asafkorem asafkorem self-assigned this Oct 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Rosetta Simulator Instructions
4 participants