Fix healthkit support for iOS > 16.1 #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
amazing contribution, thanks for that. I will review it today! |
asafkorem
approved these changes
Nov 12, 2024
| NSMutableString* query; | ||
| NSMutableString* values; | ||
| NSMutableDictionary* baseParams; | ||
| if (osVersion.majorVersion > 16 || (osVersion.majorVersion == 16 && osVersion.minorVersion > 1)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now inserts the sync_identity column for iOS 16.2 and above, where this column is now required. For earlier versions, the code omits sync_identity to maintain compatibility. I tried to follow similar logic to the rest of the code.
I tested by running the following command on iOS versions 16.1, 16.2, and 18.1:
applesimutils --byId $SIM --bundle com.my.app --setPermissions health=YESSaw error from #123 went away, and confirmed that the app bypassed the HealthKit permissions pop up.