-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add integration test for wiremock v3 #42
Open
ninadingole
wants to merge
15
commits into
wiremock:main
Choose a base branch
from
ninadingole:feat-wiremock-v3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@oleg-nenashev do you know why the build is failing for other golang versions? it says |
ninadingole
force-pushed
the
feat-wiremock-v3
branch
from
August 11, 2024 21:32
9f90676
to
57fa67d
Compare
ok figured out the issue my branch was not updated with main branch and now it seems to be fine, @oleg-nenashev need your approval please |
jamietanna
reviewed
Aug 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm adding an integration test to support wiremock v3 according to #29. All the major changes are covered as per the references provided below. GRPC and server listener are left out because more changes will be required.
To keep things simple and short, I have only covered major changes for v3 in the tests. New features like, e.g., extensions, I don't see any docs that show this was supported in the v2 version
The test is part of the same test suite in a different file, so it will run as-is with the existing CI setup. There is no change on the CI side.
Some references used to cover tests:
Submitter checklist
#help-contributing
or a project-specific channel like#wiremock-java