Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for wiremock v3 #42

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

ninadingole
Copy link

@ninadingole ninadingole commented Aug 10, 2024

I'm adding an integration test to support wiremock v3 according to #29. All the major changes are covered as per the references provided below. GRPC and server listener are left out because more changes will be required.

To keep things simple and short, I have only covered major changes for v3 in the tests. New features like, e.g., extensions, I don't see any docs that show this was supported in the v2 version

The test is part of the same test suite in a different file, so it will run as-is with the existing CI setup. There is no change on the CI side.

Some references used to cover tests:

  • wiremock v3 GA release here
  • wiremock docs here

Submitter checklist

  • Recommended: Join WireMock Slack to get any help in #help-contributing or a project-specific channel like #wiremock-java
  • The PR request is well described and justified, including the body and the references
  • The PR title represents the desired changelog entry
  • The repository's code style is followed (see the contributing guide)
  • Test coverage that demonstrates that the change works as expected
  • For new features, there's necessary documentation in this pull request or in a subsequent PR to wiremock.org

@ninadingole ninadingole marked this pull request as ready for review August 10, 2024 19:40
@ninadingole ninadingole marked this pull request as draft August 10, 2024 19:47
@ninadingole ninadingole marked this pull request as ready for review August 10, 2024 20:02
@ninadingole
Copy link
Author

@oleg-nenashev do you know why the build is failing for other golang versions? it says go mod tidy needed however, I am on vgo1.22.6 on my local and go mod tidy doesn't make any change to the go.mod file or the sum file

@ninadingole
Copy link
Author

ok figured out the issue my branch was not updated with main branch and now it seems to be fine, @oleg-nenashev need your approval please

README.md Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants