brig: make rabbitmq field optional again #4340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zebot
added
the
ok-to-test
mdimjasevic
approved these changes
Nov 13, 2024
elland
approved these changes
Nov 14, 2024
pcapriotti
force-pushed
the
brig-rabbitmq
branch
from
81ab881
to
6866ffe
Compare
echoes-hq
bot
added
the
echoes: product-roadmap/feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems the rabbitmq configuration field in brig was made mandatory by mistake in #4272. This reverts it to an optional field and removes the corresponding
Inputeffect, which was unused.Checklist
changelog.d