Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nginz and cannon ACLs to match api-versioned paths #2725

Merged
merged 3 commits into from
Sep 26, 2022
Merged

Update nginz and cannon ACLs to match api-versioned paths #2725

merged 3 commits into from
Sep 26, 2022

Conversation

pcapriotti
Copy link
Contributor

@pcapriotti pcapriotti commented Sep 23, 2022 •
edited
Loading

This PR updates the ACL files to include api-versioned paths (paths prefixed by v2/, etc).

This PR makes use of the new regex syntax in libzauth that was introduced in #2714

Checklist

  • Add a new entry in an appropriate subdirectory of changelog.d
  • Read and follow the PR guidelines

@pcapriotti pcapriotti temporarily deployed to cachix September 23, 2022 09:56 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 23, 2022 09:56 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Sep 23, 2022
@smatting smatting temporarily deployed to cachix September 23, 2022 11:33 Inactive
@smatting smatting temporarily deployed to cachix September 23, 2022 11:33 Inactive
@smatting smatting changed the title Update nginz whitelists and blacklists Update nginz and cannon ACLs Sep 23, 2022
@smatting smatting changed the title Update nginz and cannon ACLs Update nginz and cannon ACLs to match api-versioned paths Sep 23, 2022
smatting
smatting reviewed Sep 23, 2022
View reviewed changes
charts/cannon/conf/static/zauth.acl
(path "/assets/v3/**")
(path "/users")
(path "/users/**"))
a (whitelist (regex "/await"))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since cannon only have the /await route there is no need to include other rules

@smatting smatting marked this pull request as ready for review September 23, 2022 11:39
@smatting smatting self-requested a review September 23, 2022 11:40
@smatting smatting temporarily deployed to cachix September 23, 2022 11:42 Inactive
@smatting smatting temporarily deployed to cachix September 23, 2022 11:42 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 26, 2022 07:34 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix September 26, 2022 07:35 Inactive
@pcapriotti pcapriotti merged commit e6ed1e6 into develop Sep 26, 2022
@pcapriotti pcapriotti deleted the pcapriotti/update-acl branch September 26, 2022 07:35
@zebot zebot mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smatting smatting smatting approved these changes

Assignees
No one assigned
Labels
ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pcapriotti @smatting @zebot