Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add scroll view to the passcode setup view - WPB-11836 #2219

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

This PR was automatically cherry-picked based on the following PR:

Original PR description:


BugWPB-11836 [iPad] The passcode setup screen doesn't scroll, so not all the content is visible (especially with larger font category)

Issue

The screen for setting up a passcode does not scroll with large font sizes.

Solution

Add scroll view

Testing

  1. Use large fonts for the phone.
  2. Settings -> Options -> Lock with Passcode.

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@github-actions github-actions bot added cherry-pick echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. release labels Nov 27, 2024
Copy link
Contributor Author

Test Results

    2 files    288 suites   3m 2s ⏱️
1 785 tests 1 785 ✅ 0 💤 0 ❌
1 793 runs  1 793 ✅ 0 💤 0 ❌

Results for commit ee65746.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. Fix PR Title 🤦‍♂️ release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants