Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: delete dead AuthenticationStorage - WPB-10448 #2199

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

johnxnguyen
Copy link
Collaborator

@johnxnguyen johnxnguyen commented Nov 25, 2024

TaskWPB-10448 [iOS] Renew access token if needed

Issue

This PR is a follow up to #2084 in which I forgot to delete the AuthenticationStorage protocol and use the new AuthenticationManager in the PushChannelService. This PR fixes that, and also sets up an Assembly object to lazily initialize these services.


Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. label Nov 25, 2024
Copy link
Contributor

github-actions bot commented Nov 25, 2024

Test Results

195 tests   195 ✅  2s ⏱️
 27 suites    0 💤
  2 files      0 ❌

Results for commit f80b914.

♻️ This comment has been updated with latest results.

@johnxnguyen johnxnguyen added this pull request to the merge queue Nov 26, 2024
Merged via the queue into develop with commit d6ad59d Nov 26, 2024
12 checks passed
@johnxnguyen johnxnguyen deleted the chore/clean-up-dead-code-WPB-10448 branch November 26, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants