-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: create local stores and UTS - WPB-12100 #2141
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ects in storage layer
echoes-hq
bot
added
echoes: technical-roadmap
Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
echoes/initiative: ios-sync-refactoring
labels
Nov 8, 2024
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/Connections/ConnectionsLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/Connections/ConnectionsRepository.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
...omain/Sources/WireDomain/Repositories/ConversationsLabels/ConversationLabelsLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/FeatureConfig/FeatureConfigLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/FeatureConfig/Models/FeatureState.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/Team/Models/TeamMemberInfo.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
jullianm
commented
Nov 8, 2024
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/UpdateEvents/UpdateEventsLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/User/Models/NewUserInfo.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/User/Models/UserUpdateInfo.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
jullianm
commented
Nov 8, 2024
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/UserClients/UserClientsLocalStore.swift
Show resolved
Hide resolved
Test Results 8 files 934 suites 13m 18s ⏱️ Results for commit 59991d3. ♻️ This comment has been updated with latest results. |
jullianm
commented
Nov 8, 2024
WireDomain/Tests/WireDomainTests/LocalStores/ConversationLabelsLocalStoreTests.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Tests/WireDomainTests/LocalStores/FeatureConfigLocalStoreTests.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Tests/WireDomainTests/LocalStores/FeatureConfigLocalStoreTests.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
jullianm
commented
Nov 8, 2024
WireDomain/Sources/WireDomain/Repositories/Conversations/ConversationLocalStore.swift
Show resolved
Hide resolved
jullianm
commented
Nov 8, 2024
WireDomain/Tests/WireDomainTests/LocalStores/UpdateEventsLocalStoreTests.swift
Show resolved
Hide resolved
8 tasks
netbe
approved these changes
Nov 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM;)
johnxnguyen
approved these changes
Nov 27, 2024
WireDomain/Sources/WireDomain/Repositories/Connections/Models/ConnectionInfo.swift
Show resolved
Hide resolved
...omain/Sources/WireDomain/Repositories/ConversationsLabels/ConversationLabelsLocalStore.swift
Outdated
Show resolved
Hide resolved
WireDomain/Tests/WireDomainTests/LocalStores/ConversationLabelsLocalStoreTests.swift
Show resolved
Hide resolved
WireDomain/Tests/WireDomainTests/LocalStores/UpdateEventsLocalStoreTests.swift
Outdated
Show resolved
Hide resolved
WireDomain/Tests/WireDomainTests/LocalStores/UpdateEventsLocalStoreTests.swift
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring
echoes: technical-roadmap
Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Key points
This PR isolates tests for our storage layer (local stores) and revisits tests for all our existing repositories.
Missing local stores were also created so the storage logic could be moved out from related repositories.
BEFORE:
AFTER:
In addition:
Testing
Checklist
[WPB-XXX]
.UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: