Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create local stores and UTS - WPB-12100 #2141

Merged
merged 20 commits into from
Nov 27, 2024

Conversation

jullianm
Copy link
Contributor

@jullianm jullianm commented Nov 8, 2024

TaskWPB-12100 [iOS] Create remaining local stores and add UTs for all stores

Key points

This PR isolates tests for our storage layer (local stores) and revisits tests for all our existing repositories.
Missing local stores were also created so the storage logic could be moved out from related repositories.

BEFORE:

  • Local stores were indirectly tested through our repositories

AFTER:

  • Each local store is directly tested.
  • Mock local stores are injected into repositories, repositories tests were revisited consequently.

In addition:

  • Removes super.setUp() and super.tearDown() code from all tests
  • Ensures local stores know nothing about API objects (using model mappers)
  • Uses .mockID instances from WireTestingPackage
  • Harmonizes tests naming

Testing

  • Add dedicated tests for all local stores
  • Revisit repositories tests

Checklist

  • Title contains a reference JIRA issue number like [WPB-XXX].
  • Description is filled and free of optional paragraphs.
  • Adds/updates automated tests.

UI accessibility checklist

If your PR includes UI changes, please utilize this checklist:

  • Make sure you use the API for UI elements that support large fonts.
  • All colors are taken from WireDesign.ColorTheme or constructed using WireDesign.BaseColorPalette.
  • New UI elements have Accessibility strings for VoiceOver.

@echoes-hq echoes-hq bot added echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt. echoes/initiative: ios-sync-refactoring labels Nov 8, 2024
Copy link
Contributor

github-actions bot commented Nov 8, 2024

Test Results

    8 files    934 suites   13m 18s ⏱️
7 584 tests 7 584 ✅ 0 💤 0 ❌
7 592 runs  7 592 ✅ 0 💤 0 ❌

Results for commit 59991d3.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@netbe netbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM;)

@jullianm jullianm added this pull request to the merge queue Nov 27, 2024
Merged via the queue into develop with commit f1079e9 Nov 27, 2024
12 checks passed
@jullianm jullianm deleted the refactor/create-local-stores-and-UTs branch November 27, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes/initiative: ios-sync-refactoring echoes: technical-roadmap Work contributing to the Technical Roadmap, to improve our velocity or reduce the technical debt.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants