feat: open password reset link in browser - WPB-11685 #2095
+4
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echoes-hq
bot
added
the
echoes: unplanned
Test Results 2 files 305 suites 3m 23s ⏱️ Results for commit 4d19499. |
agisilaos
approved these changes
Oct 25, 2024
Datadog ReportBranch report: ✅ 0 Failed, 1866 Passed, 0 Skipped, 16.34s Total Time |
netbe
reviewed
Oct 28, 2024
| @@ -501,18 +501,9 @@ extension AuthenticationCoordinator { | |||
|
|
|||
| // MARK: - Modals | |||
|
|
|||
| /// Opens the browser and reopens the current alert upon dismissal if needed. | |||
| /// Opens the URL in the selected browser | |||
| private func openURL(_ url: URL) { | |||
There was a problem hiding this comment.
is it only password reset that uses this function?
There was a problem hiding this comment.
As far as I can tell, only the password reset uses the AuthenticationCoordinatorAction.openURL(_:) action, and only the AuthenticationCoordinatorAction.executeActions(_:) method calls it.
|
This PR is stale because it has been open 30 days with no activity. Please update it or close it in case is not relevant anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
The password reset & forgot password links should be opened in the selected browser instead of a Safari web view.
Testing
Go to account -> settings -> account -> reset password.
Tap the button. The password reset page should open in your selected browser.
Logout
Log in -> Forgot password?
Tap the link. The password reset page should open in your selected browser.
Checklist
[WPB-XXX].UI accessibility checklist
If your PR includes UI changes, please utilize this checklist: