-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow admins to remove groups [WPB-11559] #3652
base: develop
Are you sure you want to change the base?
Conversation
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #3652 +/- ##
========================================
Coverage 46.00% 46.00%
========================================
Files 472 472
Lines 16093 16102 +9
Branches 2664 2668 +4
========================================
+ Hits 7403 7408 +5
- Misses 7917 7918 +1
- Partials 773 776 +3
Continue to review full report in Codecov by Sentry.
|
Built wire-android-staging-compat-pr-3652.apk is available for download |
Built wire-android-dev-debug-pr-3652.apk is available for download |
https://wearezeta.atlassian.net/browse/WPB-11559
What's new in this PR?
Issues
Allow not only creators of the groups to delete them but also admins who are in the same team.
Solutions
Check if user has an admin role and is in the same team - if so allow him to delete the group
Testing
How to Test
PR Post Submission Checklist for internal contributors (Optional)
PR Post Merge Checklist for internal contributors
References
feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764
.