Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Highlight mentions in TextInputs (WPB-1895) #3642

Merged
merged 11 commits into from
Nov 20, 2024

Conversation

ohassine
Copy link
Member

@ohassine ohassine commented Nov 18, 2024

StoryWPB-1895 Highlight mentions in TextInputs when typing


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Description

A follow PR of #3640
This PR aims to highlight the mention inside the text field of message composer

Screen_recording_20241118_115529.webm

Needs releases with:

  • GitHub link to other pull request

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

Briefly describe how this change was tested and if applicable the exact steps taken to verify that it works as expected.

Notes (Optional)

Specify here any other facts that you think are important for this issue.

Attachments (Optional)

Attachments like images, videos, etc. (drag and drop in the text box)


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. label Nov 18, 2024
@ohassine ohassine requested review from a team, m-zagorski, yamilmedina, borichellow, MohamadJaara and vitorhugods and removed request for a team November 18, 2024 12:12
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 44.18605% with 24 lines in your changes missing coverage. Please review.

Project coverage is 45.96%. Comparing base (c1fc003) to head (6ffd4ef).
Report is 4 commits behind head on develop.

Files with missing lines Patch % Lines
.../messagecomposer/state/MessageCompositionHolder.kt 31.25% 22 Missing ⚠️
...essagecomposer/state/MessageComposerStateHolder.kt 83.33% 1 Missing ⚠️
...mposer/state/MessageCompositionInputStateHolder.kt 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3642      +/-   ##
===========================================
+ Coverage    45.95%   45.96%   +0.01%     
===========================================
  Files          472      472              
  Lines        16079    16079              
  Branches      2661     2661              
===========================================
+ Hits          7389     7391       +2     
+ Misses        7909     7907       -2     
  Partials       781      781              
Files with missing lines Coverage Δ
.../conversations/messages/item/RegularMessageItem.kt 0.00% <ø> (ø)
.../ui/home/messagecomposer/EnabledMessageComposer.kt 0.00% <ø> (ø)
...essagecomposer/state/MessageComposerStateHolder.kt 66.66% <83.33%> (ø)
...mposer/state/MessageCompositionInputStateHolder.kt 63.41% <80.00%> (+0.45%) ⬆️
.../messagecomposer/state/MessageCompositionHolder.kt 29.09% <31.25%> (+0.77%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1fc003...6ffd4ef. Read the comment docs.

---- 🚨 Try these New Features:

Copy link
Contributor

Built wire-android-staging-compat-pr-3642.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3642.apk is available for download

Copy link
Contributor

Built wire-android-staging-compat-pr-3642.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3642.apk is available for download

Copy link

sonarcloud bot commented Nov 20, 2024

@ohassine ohassine changed the title feat: Highlight mentions in TextInputs - PART 2 (WPB-1895) feat: Highlight mentions in TextInputs (WPB-1895) Nov 20, 2024
@ohassine ohassine added this pull request to the merge queue Nov 20, 2024
Merged via the queue into develop with commit 4caa4ff Nov 20, 2024
19 of 20 checks passed
@ohassine ohassine deleted the highlight-mention-textfield branch November 20, 2024 10:02
Copy link
Contributor

Built wire-android-staging-compat-pr-3642.apk is available for download

Copy link
Contributor

Built wire-android-dev-debug-pr-3642.apk is available for download

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: product-roadmap Work aligned with the customer-announced roadmap, targeting a specific release date. size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants