Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improve logging for backups 🍒 (WPB-12113) #3608

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Nov 7, 2024

Cherry-pick of:

TaskWPB-12113 [Android] Improve logging for backups


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Logging was not being performed for importing backups

Causes (Optional)

Difficulty to troubleshoot problems related to it

Solutions

Implement logging, to add more info about failures.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

Depends on

How to Test

Fail to import a backup, you should see more info related to the failure.


PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@echoes-hq echoes-hq bot added the echoes: technical-roadmap/technical-debt Changes intended at mitigating risks label Nov 7, 2024
@yamilmedina yamilmedina requested review from a team, m-zagorski, borichellow, vitorhugods, saleniuk, damian-kaczmarek, MohamadJaara, Garzas and ohassine and removed request for a team November 7, 2024 15:26
Copy link

sonarcloud bot commented Nov 7, 2024

@yamilmedina yamilmedina added this pull request to the merge queue Nov 7, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.33%. Comparing base (8f9cd86) to head (6c1f0d9).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3608      +/-   ##
===========================================
- Coverage    45.33%   45.33%   -0.01%     
===========================================
  Files          472      472              
  Lines        15795    15794       -1     
  Branches      2632     2632              
===========================================
- Hits          7161     7160       -1     
  Misses        7884     7884              
  Partials       750      750              
Files with missing lines Coverage Δ
.../home/settings/backup/BackupAndRestoreViewModel.kt 87.11% <100.00%> (-0.08%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f9cd86...6c1f0d9. Read the comment docs.

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-staging-compat-pr-3608.apk is available for download

Copy link
Contributor

github-actions bot commented Nov 7, 2024

Built wire-android-dev-debug-pr-3608.apk is available for download

Merged via the queue into develop with commit e3c1dee Nov 7, 2024
13 of 14 checks passed
@yamilmedina yamilmedina deleted the chore/improv-backup-logging-pick branch November 7, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
echoes: technical-roadmap/technical-debt Changes intended at mitigating risks size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants