fix: button keeps spinning when user starts a conversation and back (WPB-5862) 🍒

[github-actions]

WPB-5862 [Android] "Start conversation" button keeps spinning when user starts a conversation and clicks on back button.

This PR was automatically cherry-picked based on the following PR:

• fix: button keeps spinning when user starts a conversation and back (WPB-5862) #3372

Original PR description:

---

---

PR Submission Checklist for internal contributors

• The PR Title

  • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
  • contains a reference JIRA issue number like SQPIT-764
  • answers the question: If merged, this PR will: ... ³

• The PR Description

  • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

---

What's new in this PR?

Issues

When the user goes to open conversation, and comes back, the loading indicator keeps loading indefinitely.

Causes (Optional)

Not reassigning new state in view model.

Solutions

Fix it, and add missing checks in tests

Testing

Test Coverage (Optional)

• I have added automated test to this contribution

---

PR Post Submission Checklist for internal contributors (Optional)

• Wire's Github Workflow has automatically linked the PR to a JIRA issue

---

PR Post Merge Checklist for internal contributors

• If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

---

References

1. https://sparkbox.com/foundry/semantic_commit_messages
2. https://github.com/wireapp/.github#usage
3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 44.75%. Comparing base (682d006) to head (3ef0fb8).
Report is 1 commits behind head on release/candidate.

Files	Patch %	Lines
...d/ui/connection/ConnectionActionButtonViewModel.kt	66.66%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@                Coverage Diff                 @@
##           release/candidate    #3386   +/-   ##
==================================================
  Coverage              44.75%   44.75%           
==================================================
  Files                    456      456           
  Lines                  15403    15404    +1     
  Branches                2574     2574           
==================================================
+ Hits                    6893     6894    +1     
  Misses                  7783     7783           
  Partials                 727      727           

Files	Coverage Δ
...d/ui/connection/ConnectionActionButtonViewModel.kt	71.42% <66.66%> (+0.31%)	⬆️

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 682d006...3ef0fb8. Read the comment docs.

[github-actions]

Built wire-android-staging-compat-pr-3386.apk is available for download