Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for optgroup removal #9434

Merged
merged 2 commits into from
Aug 25, 2023
Merged

Account for optgroup removal #9434

merged 2 commits into from
Aug 25, 2023

Conversation

annevk
Copy link
Member

@annevk annevk commented Jun 16, 2023

This builds on whatwg/dom#1210 and together they fix #9390.


/form-elements.html ( diff )
/infrastructure.html ( diff )

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although tests would probably be a good idea? @dbaron might also want to take a look.

source Outdated Show resolved Hide resolved
@annevk annevk merged commit aceb2e3 into main Aug 25, 2023
1 check passed
@annevk annevk deleted the annevk/optgroup-removal branch August 25, 2023 10:54
@annevk
Copy link
Member Author

annevk commented Aug 25, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

issues with optionality of oldParent in HTML element removing steps, particularly with removal of optgroups
2 participants