Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: Update uses of WebIDL "invoke a callback function" #10543

Merged
merged 3 commits into from
Aug 7, 2024

Conversation

jeremyroman
Copy link
Collaborator

@jeremyroman jeremyroman commented Aug 2, 2024

It's now required for non-promise-returning uses to specify how exceptions are handled. Specifying the argument list is also made more consistent, using the shorthand syntax for lists where appropriate.

Part of whatwg/webidl#1425.

  • At least two implementers are interested (and none opposed): n/a (no normative change)
  • Tests are written and can be reviewed and commented upon at: n/a (no normative change)
  • Implementation bugs are filed: n/a (no normative change)
  • MDN issue is filed: n/a (no normative change)
  • The top of this comment includes a clear commit message to use.

(See WHATWG Working Mode: Changes for more details.)


/canvas.html ( diff )
/custom-elements.html ( diff )
/imagebitmap-and-animations.html ( diff )
/timers-and-user-prompts.html ( diff )
/webappapis.html ( diff )
/worklets.html ( diff )

It's now required for non-promise-returning uses to specify how
exceptions are handled. Specifying the argument list is also made more
consistent, using the shorthand syntax for lists where appropriate.

Part of whatwg/webidl#1425.
@jeremyroman
Copy link
Collaborator Author

@domenic ptal?

Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some missing quotes, tweaked some nearby stuff for the events case, and made some more wording uniform. I also did one case you missed, the custom element callback reactions.

As such, I'd like to ask for review of my commit from you, and thne we can merge :)

@jeremyroman
Copy link
Collaborator Author

Split a run-on sentence in the note, as it had gotten a little unwieldy. Not sure how I missed the custom element reactions one in the final version; must have hit undo one too many times at some point, or something.

@domenic domenic merged commit a607170 into whatwg:main Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration Better coordination across standards needed
Development

Successfully merging this pull request may close these issues.

2 participants