fix: do not check against current time

whatwedo · Aug 9, 2023 · b16fd8b · b16fd8b
1 parent 4df1fb0
commit b16fd8b
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/src/Manager/ExecutionManager.php b/src/Manager/ExecutionManager.php
@@ -113,8 +113,7 @@ public function isRunNeeded(CronInterface $cronJob): bool
 
         // Get next execution date
         $nextExecutionDate = $this->getNextExecutionDate($cronJob);
-        $now = new \DateTime();
-        if ($nextExecutionDate > $now) {
+        if (!$nextExecutionDate) {
             $this->logger->debug(sprintf('%s do not need to run. Next run at %s', $cronJob::class, $nextExecutionDate->format('Y-m-d H:i:s')));
 
             return false;
@@ -129,7 +128,7 @@ public function isRunNeeded(CronInterface $cronJob): bool
 
         // Check if previous execution still running
         $lastExecution = $this->getLastExecution($cronJob);
-        if ($lastExecution->getState() === Execution::STATE_RUNNING) {
+        if ($lastExecution && $lastExecution->getState() === Execution::STATE_RUNNING) {
             $this->logger->debug(sprintf('%s has a still running previous execution. Skipping it until previous execution finished.', $cronJob::class));
 
             return false;