Add WP-specific package for Atom #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add WP-specific package for snippets / auto-completion for Atom
GaryJones
requested changes
Feb 1, 2018
index.md
Outdated
| @@ -107,7 +107,9 @@ Base Tools | |||
| - [PHPStorm integration](https://github.com/xwp/wp-phpstorm) | |||
| - [PHPStorm code style](https://github.com/Automattic/PhpStorm-Resources) | |||
| - [Brackets](https://github.com/Tusko/brackets-wp-hint/) | |||
| - [Atom](https://atom.io/) | |||
| - [Atom](https://atom.io/) - Search 'wordpress' keyword on [Atom packages repository](https://atom.io/packages) | |||
There was a problem hiding this comment.
Let's drop this line - the point here is to link directly do useful WP packages, not link to an IDE and then tell folks how to search.
index.md
Outdated
| @@ -107,7 +107,9 @@ Base Tools | |||
| - [PHPStorm integration](https://github.com/xwp/wp-phpstorm) | |||
| - [PHPStorm code style](https://github.com/Automattic/PhpStorm-Resources) | |||
| - [Brackets](https://github.com/Tusko/brackets-wp-hint/) | |||
| - [Atom](https://atom.io/) | |||
| - [Atom](https://atom.io/) - Search 'wordpress' keyword on [Atom packages repository](https://atom.io/packages) | |||
| - [WordPress Core API Support](https://atom.io/packages/wordpress-api) - WordPress Core API Support for Atom Editor. | |||
There was a problem hiding this comment.
Can you add the word "Atom" at the start of the link text? Then the description can be removed.
index.md
Outdated
| - [Atom](https://atom.io/) | ||
| - [Atom](https://atom.io/) - Search 'wordpress' keyword on [Atom packages repository](https://atom.io/packages) | ||
| - [WordPress Core API Support](https://atom.io/packages/wordpress-api) - WordPress Core API Support for Atom Editor. | ||
| - [ Autocomplete WordPress Hooks](https://atom.io/packages/autocomplete-wordpress-hooks) - Autocomplete support for WordPress actions and filters in the Atom editor. |
There was a problem hiding this comment.
Add the word "Atom" here as well, and watch for the leading space at the start of the link text.
tfrommen
reviewed
Feb 2, 2018
index.md
Outdated
| @@ -107,7 +107,8 @@ Base Tools | |||
| - [PHPStorm integration](https://github.com/xwp/wp-phpstorm) | |||
| - [PHPStorm code style](https://github.com/Automattic/PhpStorm-Resources) | |||
| - [Brackets](https://github.com/Tusko/brackets-wp-hint/) | |||
| - [Atom](https://atom.io/) | |||
| - [Atom WordPress Core API Support](https://atom.io/packages/wordpress-api) | |||
There was a problem hiding this comment.
These are both still indented, and thus sub-list items.
GaryJones
approved these changes
Feb 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add WP-specific package for snippets / auto-completion for Atom