Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plop plugin #851

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Add plop plugin #851

merged 3 commits into from
Nov 25, 2024

Conversation

ben-eb
Copy link
Contributor

@ben-eb ben-eb commented Nov 25, 2024

Hello 👋

We use Plop quite a bit for managing boilerplate, it would be nice if it could be automatically added to the configuration.

Thanks!

@webpro
Copy link
Collaborator

webpro commented Nov 25, 2024

Thanks @ben-eb! Looks great, no notes :)

@webpro
Copy link
Collaborator

webpro commented Nov 25, 2024

Any chance you could run bun run format from root of repo?

Copy link

pkg-pr-new bot commented Nov 25, 2024

Open in Stackblitz

npm i https://pkg.pr.new/knip@851

commit: 6899a7b

@ben-eb
Copy link
Contributor Author

ben-eb commented Nov 25, 2024

Looks like the tests are failing due to a couple missed assertions. Will fix up (for some reason these are passing locally which is strange as I am also running OS X)

@webpro webpro merged commit 060b28d into webpro-nl:main Nov 25, 2024
23 checks passed
@webpro
Copy link
Collaborator

webpro commented Nov 26, 2024

🚀 This pull request is included in v5.38.0. See Release 5.38.0 for release notes.

Using Knip in a commercial project? Please consider becoming a sponsor.

@webpro
Copy link
Collaborator

webpro commented Nov 26, 2024

Thanks again @ben-eb!

@ben-eb ben-eb deleted the feat/plop branch November 27, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants