Minor fixes in git ignores parser

webpro-nl · Mar 25, 2024 · ec11f37 · ec11f37
1 parent 4c3160b
commit ec11f37
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/knip/src/util/globby.ts b/packages/knip/src/util/globby.ts
@@ -39,7 +39,7 @@ function convertGitignoreToMicromatch(pattern: string) {
   if (pattern.startsWith('*/**/')) pattern = pattern.slice(5);
 
   if (pattern.startsWith('/')) pattern = pattern.slice(1);
-  else pattern = '**/' + pattern;
+  else if (!pattern.startsWith('**/')) pattern = '**/' + pattern;
 
   if (pattern.endsWith('/*')) extPattern = pattern;
   else if (pattern.endsWith('/')) extPattern = pattern + '**';
@@ -53,7 +53,7 @@ function parseGitignoreFile(filePath: string) {
   return file
     .split(/\r?\n/)
     .filter(line => line && !line.startsWith('#'))
-    .map(pattern => convertGitignoreToMicromatch(pattern));
+    .map(pattern => convertGitignoreToMicromatch(pattern.replace(/#.*/, '').trim()));
 }
 
 async function parseFindGitignores(options: Options): Promise<Gitignores> {