Return undefined if no manifest (shouldn't happen anyway)

webpro-nl · Feb 23, 2024 · 624c001 · 624c001
1 parent 0b11c77
commit 624c001
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/packages/knip/src/ConfigurationChief.ts b/packages/knip/src/ConfigurationChief.ts
@@ -365,7 +365,7 @@ export class ConfigurationChief {
   }
 
   public getManifestForWorkspace(dir: string) {
-    return this.availableWorkspaceManifests?.find(item => item.dir === dir)?.manifest ?? {};
+    return this.availableWorkspaceManifests?.find(item => item.dir === dir)?.manifest;
   }
 
   public getIncludedWorkspaces() {

diff --git a/packages/knip/src/index.ts b/packages/knip/src/index.ts
@@ -145,6 +145,8 @@ export const main = async (unresolvedConfiguration: CommandLineOptions) => {
     const manifest = chief.getManifestForWorkspace(dir);
     const { ignoreBinaries, ignoreDependencies } = chief.getIgnores(name);
 
+    if (!manifest) continue;
+
     deputy.addWorkspace({ name, cwd, dir, manifestPath, manifest, ignoreBinaries, ignoreDependencies });
     const dependencies = deputy.getDependencies(name);