feat: add retainCodecs and retainCandidates functions #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
approved these changes
Aug 10, 2023
src/munge.ts
Outdated
| * @param sdpOrAv - The {@link Sdp} or {@link AvMediaDescription} from which to filter codecs. | ||
| * @param allowedCodecNames - The names of the codecs that should remain in the SDP. | ||
| */ | ||
| export function filterCodecs( |
There was a problem hiding this comment.
Wondering if we can name this something better...I feel like there's ambiguity around if the passed list are the ones being kept or the ones being removed.
There was a problem hiding this comment.
Sure, I can also rename filterCandidates to retainCandidates.
bbaldino
approved these changes
Aug 10, 2023
brycetham
changed the title
bbaldino
pushed a commit
that referenced
this pull request
Aug 10, 2023
# [1.5.0](v1.4.1...v1.5.0) (2023-08-10) ### Features * add retainCodecs and retainCandidates functions ([#18](#18)) ([8bbb081](8bbb081))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
retainCodecsandretainCandidatesfunctions tomunge.ts, as part of SPARK-411372. These functions can accept either a parsedSdpobject or anAvMediaDescriptionobject.I have also updated
removeCodecto also accept either anSdpor anAvMediaDescription.