Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove force exit from blackbox tests #7397

Merged
merged 3 commits into from
Nov 19, 2024
Merged

fix: remove force exit from blackbox tests #7397

merged 3 commits into from
Nov 19, 2024

Conversation

krzysu
Copy link
Contributor

@krzysu krzysu commented Nov 18, 2024

Fixes #7229
Fixes #7228

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

github-actions bot commented Nov 18, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 648.95 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 630.19 kB 0%
../lib/commonjs/index.d.ts 8.72 kB 0%
../lib/commonjs/accounts.d.ts 3.06 kB 0%
../lib/commonjs/types.d.ts 2.73 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 1.06 kB 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0f479d4 Previous: 5437fbc Ratio
processingTx 23120 ops/sec (±8.34%) 23185 ops/sec (±7.07%) 1.00
processingContractDeploy 40937 ops/sec (±7.87%) 39369 ops/sec (±7.85%) 0.96
processingContractMethodSend 16891 ops/sec (±7.25%) 16560 ops/sec (±6.83%) 0.98
processingContractMethodCall 28195 ops/sec (±8.27%) 27873 ops/sec (±6.86%) 0.99
abiEncode 45917 ops/sec (±7.16%) 44185 ops/sec (±8.48%) 0.96
abiDecode 31081 ops/sec (±8.19%) 31247 ops/sec (±7.26%) 1.01
sign 1572 ops/sec (±0.87%) 1579 ops/sec (±0.89%) 1.00
verify 368 ops/sec (±2.77%) 371 ops/sec (±0.50%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.51%. Comparing base (5437fbc) to head (0f479d4).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7397   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files         218      218           
  Lines        8557     8557           
  Branches     2364     2364           
=======================================
  Hits         8088     8088           
  Misses        469      469           
Flag Coverage Δ
UnitTests 94.51% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---- 🚨 Try these New Features:

@krzysu
Copy link
Contributor Author

krzysu commented Nov 18, 2024

The tests appear to run successfully without --forceExit (see the results here). I’ll revert the workflow changes before merging; the change was made temporarily to trigger the blackbox tests in this PR.

@danforbes
Copy link
Contributor

It looks like not all of the CI actions are running...

@krzysu
Copy link
Contributor Author

krzysu commented Nov 19, 2024

@danforbes Oh yes, I temporarily disabled some tests to speed up the CI during testing. I’ve re-enabled them now, so everything should be fine. Before merging this PR, I’ll revert the blackbox workflow changes. I just want to demonstrate that they are running correctly. 🚀

@krzysu krzysu merged commit 6379aa8 into 4.x Nov 19, 2024
54 checks passed
@krzysu krzysu deleted the 7229-blackbox-tests branch November 19, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web3 esm blackbox tests updates/fixes Web3 cjs blackbox tests update/fixes
2 participants