-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove force exit from blackbox tests #7397
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0f479d4 | Previous: 5437fbc | Ratio |
---|---|---|---|
processingTx |
23120 ops/sec (±8.34% ) |
23185 ops/sec (±7.07% ) |
1.00 |
processingContractDeploy |
40937 ops/sec (±7.87% ) |
39369 ops/sec (±7.85% ) |
0.96 |
processingContractMethodSend |
16891 ops/sec (±7.25% ) |
16560 ops/sec (±6.83% ) |
0.98 |
processingContractMethodCall |
28195 ops/sec (±8.27% ) |
27873 ops/sec (±6.86% ) |
0.99 |
abiEncode |
45917 ops/sec (±7.16% ) |
44185 ops/sec (±8.48% ) |
0.96 |
abiDecode |
31081 ops/sec (±8.19% ) |
31247 ops/sec (±7.26% ) |
1.01 |
sign |
1572 ops/sec (±0.87% ) |
1579 ops/sec (±0.89% ) |
1.00 |
verify |
368 ops/sec (±2.77% ) |
371 ops/sec (±0.50% ) |
1.01 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7397 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 218 218
Lines 8557 8557
Branches 2364 2364
=======================================
Hits 8088 8088
Misses 469 469
Flags with carried forward coverage won't be shown. Click here to find out more.
|
The tests appear to run successfully without |
It looks like not all of the CI actions are running... |
5174d98
to
2eddffb
Compare
@danforbes Oh yes, I temporarily disabled some tests to speed up the CI during testing. I’ve re-enabled them now, so everything should be fine. Before merging this PR, I’ll revert the blackbox workflow changes. I just want to demonstrate that they are running correctly. 🚀 |
2eddffb
to
9ead6ab
Compare
Fixes #7229
Fixes #7228
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.