fix: contract method types should allow any param if abi type not sup…

…plied (#6688)

* Fix default contractor and method input parameter

Previously type was [] (zero element tuple) instead of any[] which prevented passing parameters if contract aby type was not defined.

* better solution + test

Signed-off-by: Marin Petrunic <[email protected]>

* improve test

Signed-off-by: Marin Petrunic <[email protected]>

* remove expect error directives

Signed-off-by: Marin Petrunic <[email protected]>

* remove extra line

---------

Signed-off-by: Marin Petrunic <[email protected]>

packages/web3-eth-contract/src/contract.ts

@@ -113,7 +113,7 @@ type ContractBoundMethod<
 	Abi extends AbiFunctionFragment,
 	Method extends ContractMethod<Abi> = ContractMethod<Abi>,
 > = (
-	...args: Method['Inputs']
+	...args: Method['Inputs'] extends undefined|unknown ? any[] : Method['Inputs']
 ) => Method['Abi']['stateMutability'] extends 'payable' | 'pure'
 	? PayableMethodObject<Method['Inputs'], Method['Outputs']>
 	: NonPayableMethodObject<Method['Inputs'], Method['Outputs']>;

packages/web3-eth-contract/test/integration/local_account/contract_overloaded_methods.test.ts

@@ -104,14 +104,12 @@ describe('contract ERC721 overloaded functions', () => {
 	it('transferFrom with 3 invalid arguments', () => {
 		expect(() =>
 			contractDeployed.methods
-				// @ts-expect-error-next-line
 				.safeTransferFrom(1, 2, 3),
 		).toThrow('Web3 validator');
 	});
 
 	it('transferFrom with 2 arguments', () => {
 		expect(() =>
-			// @ts-expect-error-next-line
 			contractDeployed.methods.safeTransferFrom(localAccount.address, localAccount.address),
 		).toThrow('Web3 validator');
 	});

packages/web3-eth-contract/test/unit/contract_typing.test.ts

@@ -18,13 +18,31 @@ along with web3.js.  If not, see <http://www.gnu.org/licenses/>.
 /* eslint-disable jest/expect-expect */
 
 import { expectTypeOf, typecheck } from '@humeris/espresso-shot';
-import { Numbers } from 'web3-types';
+import { ContractConstructorArgs, Numbers } from 'web3-types';
 import { Contract } from '../../src/contract';
 import { erc20Abi, Erc20Interface } from '../fixtures/erc20';
 import { erc721Abi, Erc721Interface } from '../fixtures/erc721';
 import { NonPayableMethodObject, PayableMethodObject } from '../../src';
 
 describe('contract typing', () => {
+
+	describe('no abi type', () => {
+		const defaultContractInstance = new Contract([]);
+		// when using new web3.eth.Contract generic is any[] instead of never
+		const web3ContractInstance = new Contract<any[]>([]);
+
+		typecheck('should allow any contract init params', () => [
+			expectTypeOf<ContractConstructorArgs<any[]>>().not.toBe<[]>(),
+			expectTypeOf<ContractConstructorArgs<never>>().not.toBe<[]>(),
+			expectTypeOf<ContractConstructorArgs<[]>>().not.toBe<[]>(),
+		]);
+
+		typecheck('should allow any input params', () => [
+			expectTypeOf<Parameters<typeof defaultContractInstance.methods.test>>().toBe<any[]>(),
+			expectTypeOf<Parameters<typeof web3ContractInstance.methods.test>>().toBe<any[]>(),
+		]);
+
+	})
 	describe('custom abi', () => {
 		const abi = [
 			{