Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/assessments #388

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Feature/assessments #388

wants to merge 5 commits into from

Conversation

dmgarland
Copy link
Contributor

@dmgarland dmgarland commented Dec 23, 2020 •
edited
Loading

Styles for the schedule new assessment page

TODO

  • The design wants checkboxes for categories but the backend implements category as an enum. Need to change the database to support multiple categories, probably has knock-on consequences so warrants discussion.
  • Add radio buttons for source: national/local
  • Fix cukes - something about a .notice being missing: either a css issue or controller not saving properly and showing errors, needs investigation

@futuregov futuregov temporarily deployed to fg-beacon-pi-feature-as-04mo9q December 23, 2020 16:01 Inactive
@futuregov futuregov temporarily deployed to fg-beacon-pi-feature-as-04mo9q December 23, 2020 16:01 Inactive
@dmgarland
Using a default class called 'form' on form helpers
36b899d 
The legacy css was using generic selectors for form elements, e.g.
input[type="text"] which was adding unwanted styles to new form layouts.
This commit monkey patches the form helpers to set a default css class
of 'form' on form helper elements, and the form scss is now scoped with
that class, so existing forms ought to work as before and new forms
start with clean css. Once all the forms have been migrated to the style
guide then these files can be deleted.
@dmgarland
Styling new schedule page
0efcc69
@dmgarland
Rubocop
80067cf
@dmgarland
Fixing cukes
696822f
@futuregov futuregov temporarily deployed to fg-beacon-pi-feature-as-brml7l December 23, 2020 19:20 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmgarland @futuregov