Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added info message about too many files on FIM #7182

Open
wants to merge 5 commits into
base: 4.10.2
Choose a base branch
from

Conversation

JuanGarriuz
Copy link
Member

@JuanGarriuz JuanGarriuz commented Nov 29, 2024

Description

Added a info message on FIM about have to many files.

Issues Resolved

Evidence

image

Test

Go to FIM > Inventory
Check the alerts message render correctly

Check List

  • All tests pass
    • yarn test:jest
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@JuanGarriuz JuanGarriuz changed the title Added info message about many files on FIM Added info message about too many files on FIM Nov 29, 2024
@JuanGarriuz JuanGarriuz linked an issue Nov 29, 2024 that may be closed by this pull request
@JuanGarriuz JuanGarriuz marked this pull request as ready for review November 29, 2024 07:53
chantal-kelm
chantal-kelm previously approved these changes Nov 29, 2024
Copy link
Member

@chantal-kelm chantal-kelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ✅
TEST: ✅

Captura de pantalla 2024-11-29 a la(s) 11 11 00 a  m

Comment on lines 242 to 247
<EuiIconTip
content='Exporting to CSV from multiple files can lead to errors.'
size='s'
color='subdued'
type='alert'
/>
Copy link
Member

@Desvelao Desvelao Nov 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick: This table is used for other data related to the Wazuh API, so the tooltip should be generic one or customized for each data type.

If we want to add the tooltip to all the tables related to the Wazuh API, we could use a generic message instead of being specific to files (from FIM data).

guidomodarelli
guidomodarelli previously approved these changes Nov 29, 2024
Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Legend:
⚫ 🠊 The test hasn't started yet.
🟢 🠊 All checks passed.
🟡 🠊 There is at least one expected fail or skipped test and no failures.
🔴 🠊 There is at least one failed check.
⚪ 🠊 Doesn't apply.
🔧 🠊 Request changes.

CR 🟢
TEST 🟢

image

Copy link
Contributor

@guidomodarelli guidomodarelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Wazuh Check Updates plugin code coverage (Jest) test % values
Statements 76.44% ( 172 / 225 )
Branches 58.65% ( 61 / 104 )
Functions 61.7% ( 29 / 47 )
Lines 76.44% ( 172 / 225 )

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Wazuh Core plugin code coverage (Jest) test % values
Statements 45.5% ( 400 / 879 )
Branches 41.09% ( 157 / 382 )
Functions 43.87% ( 136 / 310 )
Lines 45.69% ( 398 / 871 )

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Main plugin code coverage (Jest) test % values
Statements 15.25% ( 4540 / 29763 )
Branches 10.07% ( 1943 / 19284 )
Functions 15.16% ( 1089 / 7182 )
Lines 15.46% ( 4429 / 28632 )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timeout error when exporting CSV in FIM
4 participants