Revive emit_debug_print #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frank-emrich
force-pushed
the
revive-emit_debug_print
branch
from
3ef983f
to
39c160e
Compare
dhil
reviewed
Jan 29, 2024
Comment on lines
+258
to
+260
| .match_indices("{}") | ||
| .chain(s.match_indices("{:p}")) | ||
| .collect(); |
There was a problem hiding this comment.
Does this yield the expected behaviour for a string like "{:p}{}"? Reading the code it seems like {} will be printed first.
There was a problem hiding this comment.
After this line, ph_matches would indeed contain the entry for "{}" before that of "{:p}". That's why the next line sorts the matches based on the first value of the tuple (i.e., the start index of the match).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simpler alternative to #82 that does not implement a bespoke pattern matcher, but uses two calls to
str'smatch_indicesfunction.