Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR just collects a few uncontroversial fixes and improvements of the benchmark harness:
make.generic.config
, allow specifying additional arguments passed tomake
as part of the benchmark's definition (useful for defining variants of the same benchmark)--comand-name
option to give useful names to the shell commands it compares. Thus, instead of printing the lengthy shell commands in the Summary table produced by hyperfine, it now shows the benchmark names instead--prepare-only
flag which makes the harness perform all preparation/compilation steps, but stop before actually running benchmarksuse-mimalloc
CLI flagcargo
to the list of helper tools that we look for in$PATH
and complain if they are missing