Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simple CI #5

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Simple CI #5

merged 1 commit into from
Apr 30, 2024

Conversation

frank-emrich
Copy link
Contributor

@frank-emrich frank-emrich commented Apr 24, 2024 •
edited
Loading

This PR adds to simple pieces of CI:

  1. Checking the harness itself (typing and formatting)
  2. Checking that the the full benchmark suite completes succesfully

@frank-emrich frank-emrich marked this pull request as ready for review April 29, 2024 13:47
@frank-emrich frank-emrich requested a review from dhil April 29, 2024 16:19
dhil
dhil approved these changes Apr 30, 2024
View reviewed changes
Copy link
Member

@dhil dhil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It would be good to make the CI generate a report for some suitable standard configuration with the hyperfine.

@frank-emrich
Copy link
Contributor Author

Yes, we should have something like that, but preferably as part of the wasmtime repo CI. The tests here are just meant to ensure that we don't break the benchmarks + ensuring that the setup steps described in the README.md still work, not so much for performance monitoring.

@frank-emrich frank-emrich merged commit cb7f9da into main Apr 30, 2024
2 checks passed
@dhil dhil deleted the bench-ci branch April 30, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhil dhil dhil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@frank-emrich @dhil