This repository has been archived by the owner on Jun 10, 2024. It is now read-only.
feat(xkcd)!: add simple UI to XKCD actor #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Brooks Townsend <[email protected]>
connorsmith256
approved these changes
Sep 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Brooks Townsend [email protected]
Feature or Problem
Pay no attention to the 33,000 changes, mostly static files!
This PR adds a simple UI to the XKCD example, see screenshots below. It reorders some code in the XKCD actor as well to allow for fetching the included static assets from the embedded struct.
Also, I updated the README to use
wadminstead ofmaketo deploy the actor and it should actually work with wash and all that.Related Issues
Release Information
XKCD v0.2.0
Consumer Impact
The UI changes!
The static assets are built and included with this PR, simply so that consumers of this example locally don't need
npmtowash buildthe XKCD actor.Testing
Built on platform(s)
Tested on platform(s)
Unit Test(s)
Acceptance or Integration
Manual Verification
This works!