Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker workflows to list and remove images #162

Merged
merged 19 commits into from
Oct 2, 2023

Conversation

guel-codes
Copy link
Contributor

Overview

This PR adds two docker workflows to help users list and then remove specific images

Discord username -> guel_codes#2183

Description of changes

  • specs/docker/remove_docker_images_from_local.yaml - added
    • This workflow adds a command for removing local docker images
  • specs/docker/list_docker_images_from_local.yaml - added
    • This workflow adds a command to list local docker images

Copy link
Contributor

@elviskahoro elviskahoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Have a small nit, I think we should remove the default value argument

specs/docker/remove_docker_images_from_local.yaml Outdated Show resolved Hide resolved
@elviskahoro elviskahoro enabled auto-merge (squash) September 6, 2023 01:19
@elviskahoro elviskahoro self-requested a review September 6, 2023 06:15
Copy link
Contributor

@elviskahoro elviskahoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the arguments parameter

auto-merge was automatically disabled September 6, 2023 14:19

Head branch was pushed to by a user without write access

@guel-codes
Copy link
Contributor Author

@elviskahoro I'm going to look deeper into these build errors today and hopefully have a fix soon. Apologies for all the back and forth.

@guel-codes
Copy link
Contributor Author

guel-codes commented Sep 28, 2023

@elviskahoro cargo build is working locally, we can try this again whenever you get a chance. Thanks again for all the help.

@elviskahoro
Copy link
Contributor

@elviskahoro I'm going to look deeper into these build errors today and hopefully have a fix soon. Apologies for all the back and forth.

Running CI/CD!

@elviskahoro elviskahoro self-requested a review October 2, 2023 23:56
@elviskahoro elviskahoro merged commit 9552855 into warpdotdev:main Oct 2, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants