feat: storenode cycle #1223
Merged
feat: storenode cycle #1223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richard-ramos
force-pushed
the
storenode-cycle
branch
from
d9361e5
to
3988fc6
Compare
kaichaosun
reviewed
Sep 25, 2024
richard-ramos
force-pushed
the
storenode-cycle
branch
from
b2d0226
to
b852a92
Compare
richard-ramos
force-pushed
the
storenode-cycle
branch
from
b852a92
to
f29ce5f
Compare
chaitanyaprem
approved these changes
Oct 14, 2024
There was a problem hiding this comment.
Code functionality looks good to me! hence approving it. Few comments that might be good to address now.
Some code architectural comments i have noted here, maybe these are planned as part of a subsequent refactor but wanted to indicate anyways :)
- Interface between status-go and waku api should be simple i.e status-go specifies list of storenodes to be used and waku internally manages connectivity to them and picks a storenode and manages active store. There can be one event emitter than status-go can register with to get all updates such as what is active-store-node, in case connectivity is lost etc.
- All 3 components i.e history-query, missing-messages and message-check should end up using same set of store nodes instead of their own selection criteria and logic.
- selection of storenode can be done using peer-selection and RTT. logic seems duplicated here
- store node failed requests should also consider requests made from
missing_messagesandmessage_checkso that active storenode can be switched.
I agree with the suggestions, and will work on these on a separate PR! thank you. Indeed there's a lot of duplication of code between the missing message logic, message check and the store node cycle that will need to be refactored away |
Jenkins BuildsClick to see older builds (6)
|
richard-ramos
force-pushed
the
storenode-cycle
branch
from
397b4b5
to
f40a23c
Compare
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the storenode cycle code from status-go.
I tried to simplify it a bit but most of the heavy refactoring should be done on a separate PR since this one is already complex enough.
@plopezlpz, @kaichaosun @igor-sirotin @chaitanyaprem:
I'm still working on the unit tests, but so far, while testing status-im/status-go#5857 with Desktop, it looks promising. Reviews are appreciated!