Add dark mode support for the Unicode codepoint template #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deniak
requested changes
Mar 22, 2024
| @@ -119,4 +119,6 @@ img { background: white; } | |||
| --outdated-shadow: red; | |||
|
|
|||
| --editedrec-bg: darkorange; | |||
|
|
|||
| --uname: rgb(215 99 99); | |||
There was a problem hiding this comment.
Suggested change
| --uname: rgb(215 99 99); | |
| --uname: rgb(215, 99, 99); |
There was a problem hiding this comment.
@xfq how did you come up with that color?
I checked the contract ratio and it doesn't pass WCAG AAA.
rgb(215, 140, 140) seems to work .better
There was a problem hiding this comment.
I selected it manually, because I think the contrast is good enough for me and AAA requirements are not recommended to be included in legislation by default, but I'm OK with colour you picked as well.
As for the syntax, since the recommended space-separated notation is now supported by all major browsers, I wonder if we can adopt it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sync with w3c/bp-i18n-specdev#130
/cc @aphillips