Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide redirectStart and redirectEnd for navigations with cross-origin redirects #170

Merged
merged 3 commits into from
Feb 24, 2022
Merged

Hide redirectStart and redirectEnd for navigations with cross-origin redirects #170

merged 3 commits into from
Feb 24, 2022

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Feb 8, 2022 •
edited by pr-preview bot
Loading

@noamr noamr mentioned this pull request Feb 8, 2022
Closed
@noamr noamr requested a review from yoavweiss February 13, 2022 08:25
@noamr
Copy link
Contributor Author

noamr commented Feb 13, 2022

@yoavweiss I think we can also do this without changing the HTML spec, by hiding redirectStart and redirectEnd if redirectCount is 0. Does that sound OK or too hacky/implicit?

@yoavweiss
Copy link
Contributor

I think that's reasonable.

@noamr
Copy link
Contributor Author

noamr commented Feb 24, 2022

I think that's reasonable.

Done

yoavweiss
yoavweiss approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nits

index.html Outdated
</ol>
<p class="note">
Though `redirectStart` and `redirectEnd` are exposed in <a data-cite=
"RESOURCE-TIMING-2#dom-performanceresourcetiming">PerformanceResourceTiming</a>, it
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/it has/they have/

index.html Outdated
<p class="note">
Though `redirectStart` and `redirectEnd` are exposed in <a data-cite=
"RESOURCE-TIMING-2#dom-performanceresourcetiming">PerformanceResourceTiming</a>, it
has a different meaning in Navigation Timing, which returns zero for navigations with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/which returns/where they return/

@noamr noamr merged commit 7ab0bfe into gh-pages Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoavweiss yoavweiss yoavweiss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide TAO-protected timing info from navigation timing when cross-origin redirects are present
2 participants
@noamr @yoavweiss