Fix examples #146
Open
Fix examples #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #1 - Minor cleanup to examples - Links some terms to the glossary
- Make the Hebrew and Arabic examples exactly match the text (no cheating) - Use `class=example` to highlight the example text
✅ Deploy Preview for bp-i18n-specdev ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
A small typo by the way, in example 3. Letter Noon missing at the beginning : replace شاط by نشاط |
The text was repeated, so the fix needed to be repeated also...
- Create correct/incorrect examples for each - Reword appropriately
- Add styles to the tables - Remove rowspans - Choose better Arabic fonts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
class=exampleto make the example text visible@ntounsi for visibility
Preview | Diff