Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avahi: T6908: add option to define max-cache entries #4207

Merged
merged 2 commits into from
Nov 23, 2024
Merged

avahi: T6908: add option to define max-cache entries #4207

merged 2 commits into from
Nov 23, 2024
+79 −17

Conversation

c-po
Copy link
Member

@c-po c-po commented Nov 22, 2024 •
edited
Loading

Change Summary

Add CLI option to configure cache-entries-max entries in Avahi daemon configuration.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

mDNS repeater

Proposed changes

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_mdns_repeater.py
test_service_dual_stack (__main__.TestServiceMDNSrepeater.test_service_dual_stack) ... ok
test_service_ipv4 (__main__.TestServiceMDNSrepeater.test_service_ipv4) ... ok
test_service_ipv6 (__main__.TestServiceMDNSrepeater.test_service_ipv6) ... ok
test_service_max_cache_entries (__main__.TestServiceMDNSrepeater.test_service_max_cache_entries) ... ok

----------------------------------------------------------------------
Ran 4 tests in 26.471s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@c-po
avahi: T6908: reduce runtime overhead in smoketests by using setUpCla…
fbb2dca 
…ss/tearDownClass
@c-po
avahi: T6908: add option to define mdns-repeater max-cache entries
cee96b9 
Add CLI option to configure `cache-entries-max` entries in Avahi daemon
configuration.

Default value of 4096 for "cache-entries" CVLI node was retrieved from
source code.
@c-po c-po requested a review from a team as a code owner November 22, 2024 19:39
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 22, 2024 •
edited
Loading

👍
No issues in PR Title / Commit Title

@c-po c-po mentioned this pull request Nov 22, 2024
Merged
1 task
@github-actions GitHub Actions
Copy link

CI integration 👍 passed!

Details

CI logs

  • CLI Smoketests (no interfaces) 👍 passed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@sever-sever sever-sever merged commit ec18cc3 into vyos:current Nov 23, 2024
22 of 23 checks passed
@c-po c-po deleted the avahi-T6908 branch November 23, 2024 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@sarthurdev sarthurdev sarthurdev approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

@fett0 fett0 Awaiting requested review from fett0 fett0 is a code owner automatically assigned from vyos/reviewers

Assignees

@c-po c-po

Labels
current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-po @sarthurdev @sever-sever