T6906: IPoE-server add start-session option

[sever-sever]

Change Summary

Add the abbility to start IPoE session by unclassified-packet. It allows the cases when subscriber configures the address manually (static) and accel-ppp can start session on any packet. By default start session on DHCPv4 Discover packet.

set service ipoe-server interface eth1 start-session < auto | dhcp | unclassified-packet>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T6906

Related PR(s)

Component(s) name

ipoe-server

Proposed changes

How to test

Configure start-session on unclassified-packet

set service ipoe-server authentication mode 'radius'
set service ipoe-server authentication radius server 127.0.0.1 key 'vyos-secret'
set service ipoe-server client-ip-pool POOL range '100.64.0.0/22'
set service ipoe-server gateway-address '100.64.0.1/22'
set service ipoe-server interface eth1 mode 'l2'
set service ipoe-server interface eth1 network 'shared'
set service ipoe-server interface eth1 start-session 'unclassified-packet'
set service ipoe-server name-server '1.1.1.1'
set service ipoe-server name-server '8.8.8.8'

Check config, expecting start=up:

vyos@r14# cat /run/accel-pppd/ipoe.conf | grep interface
interface=eth1,shared=1,mode=L2,ifcfg=1,start=up,ipv6=1
[edit]
vyos@r14# 

Configuration on the client site:

set interfaces ethernet eth1 address '100.64.0.10/22'

Check sessions:

vyos@r14:~$ show ipoe-server sessions 
ifname |  username   |    calling-sid    |     ip      | ip6 | ip6-dp | rate-limit | type | comp | state  |  uptime  
--------+-------------+-------------------+-------------+-----+--------+------------+------+------+--------+----------
 ipoe0  | 100.64.0.10 | 52:54:00:09:0b:01 | 100.64.0.10 |     |        |            | ipoe |      | active | 00:16:15
vyos@r14:~$ 

Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[c-po]

Can we use dhcp on the CLI please and transcode it internally as it's done for unclassified-packet? We always use dhcp on the CLI for DHCPv4 related stuff. This would keep the CLI consistent.

[sever-sever]

Done!

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[github-actions]

CI integration ❌ failed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) ❌ failed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed