serial: T3397: Remove --keep-baud which could result in unexpected baud rate

[sarthurdev]

Change Summary

Prevents serial terminals from using unexpected baud rate

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

serial, console

Proposed changes

This change removes --keep-baud which can result in an unexpected baud rate for serial terminals.

When a specific baud rate speed is defined, or it is falling back to the VyOS default value of 115200. --keep-baud can result in the config value not being honoured.

If the terminal was created with a baud rate other than the config defined value, the config value will not be applied.

How to test

Tested on a Supermicro SOL serial port mapped to /dev/ttyS1. BIOS/IPMI is set to 115200.

stty -aF /dev/ttyS1 default output:
speed 9600 baud; rows 24; columns 80; ...

After set system console device ttyS1 speed 115200:
speed 9600 baud; rows 24; columns 80; ...

Removing --keep-baud:
speed 115200 baud; rows 24; columns 80; ...

Smoketest result

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly

[github-actions]

👍
No issues in PR Title / Commit Title

[github-actions]

CI integration 👍 passed!

Details

CI logs

• CLI Smoketests (no interfaces) 👍 passed
• CLI Smoketests (interfaces only) 👍 passed
• Config tests 👍 passed
• RAID1 tests 👍 passed
• TPM tests 👍 passed