Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6682: Fix for show vpn ike sa peer that always shows all SAs #4057

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

natali-rs1985
Copy link
Contributor

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

op-mode

Proposed changes

How to test

vyos@vyos# run show vpn ike sa
Peer ID / IP                            Local ID / IP
------------                            -------------
192.168.134.187                         192.168.134.186

    State  IKEVer  Encrypt      Hash          D-H Group      NAT-T  A-Time  L-Time
    -----  ------  -------      ----          ---------      -----  ------  ------
    down   IKEv1   n/a          n/a           n/a            no     0       0

Peer ID / IP                            Local ID / IP
------------                            -------------
192.168.134.185                         192.168.134.186

    State  IKEVer  Encrypt      Hash          D-H Group      NAT-T  A-Time  L-Time
    -----  ------  -------      ----          ---------      -----  ------  ------
    down   IKEv1   n/a          n/a           n/a            no     0       0

[edit]


vyos@vyos# run show vpn ike sa peer 192.168.134.187
Peer ID / IP                            Local ID / IP
------------                            -------------
192.168.134.187                         192.168.134.186

    State  IKEVer  Encrypt      Hash          D-H Group      NAT-T  A-Time  L-Time
    -----  ------  -------      ----          ---------      -----  ------  ------
    down   IKEv1   n/a          n/a           n/a            no     0       0

[edit]

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 12, 2024

👍
No issues in PR Title / Commit Title

Copy link

✅ No issues found in unused-imports check.. Please refer the workflow run

@c-po
Copy link
Member

c-po commented Sep 12, 2024

@natali-rs1985 do we need backports for circinus and sagiita?

@natali-rs1985
Copy link
Contributor Author

@natali-rs1985 do we need backports for circinus and sagiita?

yes, we do.

@dmbaturin dmbaturin changed the title op-mode: T6682: Fix for show vpn ike sa peer always shows all SAs op-mode: T6682: Fix for show vpn ike sa peer that always shows all SAs Sep 15, 2024
@dmbaturin dmbaturin merged commit be892a0 into vyos:current Sep 15, 2024
15 of 17 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport circinus sagitta

Copy link
Contributor

mergify bot commented Sep 15, 2024

backport circinus sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request Sep 16, 2024
op-mode: T6682: Fix for show vpn ike sa peer that always shows all SAs (backport #4057)
c-po added a commit that referenced this pull request Sep 16, 2024
op-mode: T6682: Fix for show vpn ike sa peer that always shows all SAs (backport #4057)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants