wireguard: T5413: Blocked adding the peer with the router's public key #2540
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disabled adding the peer with the same public key as the router has. Backport from current vyos#2122
vyosbot
requested review from
a team,
dmbaturin,
sarthurdev,
zdc,
jestabro,
sever-sever and
c-po
and removed request for
a team
aapostoliuk
added a commit
to aapostoliuk/vyatta-cfg-system
that referenced
this pull request
Nov 24, 2023
Migration dependencies Related to vyos/vyos-1x#2540
dmbaturin
approved these changes
Dec 7, 2023
sever-sever
approved these changes
Dec 7, 2023
|
Let's merge it after 1.3.5 release |
|
Please note - after this merged we need to properly shift all migrators in 1.4 that have a higher number then 22 as there is now a 22-to-23 in an "older" LTS release. This is required so the config is still properly migrated from 1.3.6 -> 1.4.0 |
c-po
added a commit
to c-po/vyos-1x
that referenced
this pull request
Dec 10, 2023
PR vyos#2540 backported a migration script from current to the equuleus LTS branch. As migration scripts are executed in order to adjust the CLI for necessary improvements in future LTS releases we need to change the versioning of the migration files to match the new "base" version from the previous LTS release. In theory this could break very ancient 1.4 rolling releases (from the early days of the OSPF refactoring) - but those versions are considered very much unstable. Now this is the last chance to sync up the migration scripts before the 1.4 LTS release.
12 tasks
mergify bot
pushed a commit
that referenced
this pull request
Dec 10, 2023
PR #2540 backported a migration script from current to the equuleus LTS branch. As migration scripts are executed in order to adjust the CLI for necessary improvements in future LTS releases we need to change the versioning of the migration files to match the new "base" version from the previous LTS release. In theory this could break very ancient 1.4 rolling releases (from the early days of the OSPF refactoring) - but those versions are considered very much unstable. Now this is the last chance to sync up the migration scripts before the 1.4 LTS release. (cherry picked from commit 98ca098)
jestabro
pushed a commit
to jestabro/vyos-1x
that referenced
this pull request
Dec 11, 2023
PR vyos#2540 backported a migration script from current to the equuleus LTS branch. As migration scripts are executed in order to adjust the CLI for necessary improvements in future LTS releases we need to change the versioning of the migration files to match the new "base" version from the previous LTS release. In theory this could break very ancient 1.4 rolling releases (from the early days of the OSPF refactoring) - but those versions are considered very much unstable. Now this is the last chance to sync up the migration scripts before the 1.4 LTS release.
jestabro
pushed a commit
to jestabro/vyos-1x
that referenced
this pull request
Dec 11, 2023
PR vyos#2540 backported a migration script from current to the equuleus LTS branch. As migration scripts are executed in order to adjust the CLI for necessary improvements in future LTS releases we need to change the versioning of the migration files to match the new "base" version from the previous LTS release. In theory this could break very ancient 1.4 rolling releases (from the early days of the OSPF refactoring) - but those versions are considered very much unstable. Now this is the last chance to sync up the migration scripts before the 1.4 LTS release.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Disabled adding the peer with the same public key as the router has.
Backported from the current version.
#2122
Types of changes
Related Task(s)
Related PR(s)
vyos/vyatta-cfg-system#216
Component(s) name
wireguard
Proposed changes
Disabled adding the peer with the same public key as the router has.
Backported from the current version.
#2122
How to test
Smoketest result
vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_interfaces_wireguard.py
test_wireguard_add_remove_peer (main.WireGuardInterfaceTest) ... ok
test_wireguard_peer (main.WireGuardInterfaceTest) ... ok
test_wireguard_same_public_key (main.WireGuardInterfaceTest) ...
Peer "PEER01" has the same public key as the interface "wg0"
ok
Ran 3 tests in 14.169s
OK
Checklist: